-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] event_pusher check if the recipient is not a room #3551
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3551 +/- ##
==========================================
- Coverage 79.26% 79.21% -0.06%
==========================================
Files 420 420
Lines 32266 32269 +3
==========================================
- Hits 25577 25563 -14
- Misses 6689 6706 +17
Continue to review full report at Codecov.
|
small_tests_24 / small_tests / ef5ac52 small_tests_23 / small_tests / ef5ac52 dynamic_domains_mysql_redis_24 / mysql_redis / ef5ac52 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / ef5ac52 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / ef5ac52 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / ef5ac52 ldap_mnesia_24 / ldap_mnesia / ef5ac52 ldap_mnesia_23 / ldap_mnesia / ef5ac52 internal_mnesia_24 / internal_mnesia / ef5ac52 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / ef5ac52 pgsql_mnesia_24 / pgsql_mnesia / ef5ac52 mysql_redis_24 / mysql_redis / ef5ac52 pgsql_mnesia_23 / pgsql_mnesia / ef5ac52 mssql_mnesia_24 / odbc_mssql_mnesia / ef5ac52 riak_mnesia_24 / riak_mnesia / ef5ac52 |
from = From, to = To, packet = Packet}, | ||
NewAcc = mod_event_pusher:push_event(Acc0, Host, Event), | ||
merge_acc(Acc0, NewAcc) | ||
case mongoose_lib:is_to_room(To) of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, Type
is the message type, that is, it can be the atom groupchat, so you might as well filter there too, you might want to call is_to_room
only if the message is actually to a groupchat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, true
Just want to see if this passes on CI