Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor mam suite #4237

Merged
merged 4 commits into from
Mar 8, 2024
Merged

Refactor mam suite #4237

merged 4 commits into from
Mar 8, 2024

Commits on Mar 7, 2024

  1. Export all functions from mam_helper and mam_SUITE 

    We do this for other suites, and the long export lists are
tedious to maintain.
    @chrzaszcz
    chrzaszcz committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    c2f5a08 View commit details
    Browse the repository at this point in the history

  2. Refactor skipping tests in mam_SUITE

    @chrzaszcz
    chrzaszcz committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    615840e View commit details
    Browse the repository at this point in the history

  3. Set up required modules for each test case in mam_SUITE 

    This simplifies test initialisation, and makes the whole setup more
predictable.
    @chrzaszcz
    chrzaszcz committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    b1bcf9c View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Reimplement init_per_testcase as a list of steps 

    Reasons: code reuse, DRY, maintainability

Also:
- Rework and simplify end_per_testcase
- Minor fix: don't start room for a few non-MUC cases
    @chrzaszcz
    chrzaszcz committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    5ea8c57 View commit details
    Browse the repository at this point in the history