Add cets_discovery:wait_for_get_nodes/2 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function blocks until get_nodes returns
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
==========================================
+ Coverage 98.19% 98.21% +0.01%
==========================================
Files 10 10
Lines 719 727 +8
==========================================
+ Hits 706 714 +8
Misses 13 13 ☔ View full report in Codecov by Sentry. |
chrzaszcz
approved these changes
Nov 28, 2023
Add disco_wait_for_get_nodes_when_get_nodes_needs_to_be_retried testcase
arcusfelis
force-pushed
the
wait-for-get-nodes
branch
from
47eebc7
to
ac1afc3
Compare
chrzaszcz
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
The added function waits for the get_nodes function to finish. It is difficult to say if it fixes the race conditions, because it is not described what it is supposed to fix. I can approve, because it works as described. We will see how it fits into MongooseIM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function blocks until get_nodes returns