feat!: Start using `enhanced-resolve` to improve ts support #139

scagood · 2023-11-09T22:14:23Z

This PR is going to aim to:

I am going to be making the following changes:

Change to using enhanced-resolve
Check for and resolve "import type" in import-target
Attempt to import and check typescript "paths"
Allow for passing ts extensions into the resolve function

scagood · 2023-11-26T16:04:48Z

tests/lib/rules/file-extension-in-import.js

        {
+            // name: '.js has a higher priority than .json'
            filename: fixture("test.js"),
            code: "import './multi'",
-            output: null,
+            output: "import './multi.js'",
            options: ["always"],
-            errors: [
-                { messageId: "requireExt", data: { ext: ".cjs or .mjs" } },
-            ],
+            errors: [{ messageId: "requireExt", data: { ext: ".js" } }],
+        },
+        {
+            filename: fixture("test.js"),
+            code: "import './multi.js'",
+            output: null,
+            options: ["never"],
+            errors: [{ messageId: "forbidExt", data: { ext: ".js" } }],
        },
        {
            filename: fixture("test.js"),
-            code: "import './multi.cjs'",
+            code: "import './multi.json'",
            output: null,
            options: ["never"],
-            errors: [{ messageId: "forbidExt", data: { ext: ".cjs" } }],
+            errors: [{ messageId: "forbidExt", data: { ext: ".json" } }],
        },


These multi tests did not make sense, as you cant import .cjs or .mjs files without a file extension. (that I know of / found)

I have thus swapped the test to use .js and .json.
This means that we can use the correct import priority as a fixer.

I'm wondering if suggestion would be more appropriate: https://eslint.org/docs/latest/extend/custom-rules#providing-suggestions

generally, it's a best practice to not change the runtime behavior in fixers.

🤔 We can try to do that!

lib/rules/file-extension-in-import.js

scagood · 2023-11-26T16:10:42Z

lib/util/import-target.js

+        if (isBuiltin(this.name)) {
+            return "node"
+        }
+
+        if (/^(@[\w~-][\w.~-]*\/)?[\w~-][\w.~-]*/.test(this.name)) {
+            return "npm"
+        }


I wonder what to do with these when people use the @organisation/package in path aliases.

aladdin-add · 2023-12-15T09:53:37Z

I was waiting for eslint v9 to be released, and to see if there are some other breaking changes needed.

It's fine to put it in one PR. I'll review it later, sorry for the delay. :😏

scagood · 2023-12-15T10:00:59Z

Ah cool! That makes complete sense 😁

I was just thinking about this comment #147 (comment). More specifically about trying to implement the settings.import/resolver api in here as well.

You're 100% right, I can hold my horses though, stability is far more important!

lib/rules/file-extension-in-import.js

lib/util/import-target.js

package.json

aladdin-add · 2023-12-18T03:57:08Z

tests/lib/rules/file-extension-in-import.js

        {
+            // name: '.js has a higher priority than .json'
            filename: fixture("test.js"),
            code: "import './multi'",
-            output: null,
+            output: "import './multi.js'",
            options: ["always"],
-            errors: [
-                { messageId: "requireExt", data: { ext: ".cjs or .mjs" } },
-            ],
+            errors: [{ messageId: "requireExt", data: { ext: ".js" } }],
+        },
+        {
+            filename: fixture("test.js"),
+            code: "import './multi.js'",
+            output: null,
+            options: ["never"],
+            errors: [{ messageId: "forbidExt", data: { ext: ".js" } }],
        },
        {
            filename: fixture("test.js"),
-            code: "import './multi.cjs'",
+            code: "import './multi.json'",
            output: null,
            options: ["never"],
-            errors: [{ messageId: "forbidExt", data: { ext: ".cjs" } }],
+            errors: [{ messageId: "forbidExt", data: { ext: ".json" } }],
        },


I'm wondering if suggestion would be more appropriate: https://eslint.org/docs/latest/extend/custom-rules#providing-suggestions

generally, it's a best practice to not change the runtime behavior in fixers.

tests/lib/rules/no-missing-require.js

SlyryD

Looking forward to the improved support!

aladdin-add

awesome work, thanks for doing this!

The changes look good; let's merge them when we are preparing for the v17 release in our development.

aladdin-add · 2024-01-08T09:47:20Z

looks we have a conflict now. @scagood

scagood · 2024-01-08T09:57:04Z

mmmm, its not a simple merge. I will rebase later 😂

Co-authored-by: Sebastian Good <[email protected]>

scagood force-pushed the resolve branch 2 times, most recently from 3ccd883 to 8e0dcb7 Compare November 10, 2023 10:25

This comment was marked as outdated.

Sign in to view

scagood added this to the v17 milestone Nov 22, 2023

scagood force-pushed the resolve branch 2 times, most recently from 9510597 to aa800e5 Compare November 25, 2023 16:57

scagood commented Nov 26, 2023

View reviewed changes

scagood changed the title ~~[WIP] type only module marked as missing~~ feat!: Start using enhanced-resolve to improve ts support Nov 26, 2023

scagood requested a review from a team November 26, 2023 16:30

scagood marked this pull request as ready for review November 26, 2023 16:30

This was referenced Nov 26, 2023

Self imports are not working #86

Closed

feat: eslint v9.0.0 compatibility (fixes #143) #144

Merged

scagood force-pushed the resolve branch from e05b22d to d9a7882 Compare December 11, 2023 09:15

scagood requested a review from aladdin-add December 11, 2023 09:21

scagood mentioned this pull request Dec 11, 2023

Bug: no-extraneous-import doesn't support import maps #147

Closed

1 task

aladdin-add mentioned this pull request Dec 15, 2023

chore: update dependency esbuild to ^0.19.0 #148

Closed

1 task

This comment was marked as outdated.

Sign in to view

aladdin-add reviewed Dec 18, 2023

View reviewed changes

scagood mentioned this pull request Dec 19, 2023

[file-extension-in-import] Does not work properly in TypeScript projects with allowImportingTsExtensions #134

Closed

1 task

SlyryD approved these changes Dec 30, 2023

View reviewed changes

scagood force-pushed the resolve branch from e7f1565 to a8d2687 Compare January 2, 2024 15:09

aladdin-add approved these changes Jan 3, 2024

View reviewed changes

aladdin-add mentioned this pull request Jan 3, 2024

v17 planned changes #158

Closed

aladdin-add marked this pull request as draft January 3, 2024 03:14

scagood mentioned this pull request Jan 4, 2024

feat!: drop eslint v7 & node.js < 18 #161

Merged

aladdin-add marked this pull request as ready for review January 8, 2024 09:44

scagood and others added 12 commits January 9, 2024 09:49

chore: remove "enhanced-resolve" from "no-hide-core-modules"

b0c0fed

test: Add a test for eslint-community#66

609bdc2

feat!: Allow ts paths aliases (eslint-community#84)

6623a68

feat: Allow for "allowImportingTsExtensions" (eslint-community#134)

7818a8f

feat: Add test for import maps (eslint-community#147)

f033dce

Update lib/util/import-target.js

96389b9

Co-authored-by: Sebastian Good <[email protected]>

test: Add test for n/no-missing-require eslint/use-at-your-own-risk

6ee32ff

chore: Remove esbuild

1d421cc

feat: Allow for settings.cwd to be used before process.cwd

b8aa4f8

chore: replace reference to eslint/use-at-your-own-risk

83dc99f

chore: Remove more unused packages

9945cda

chore: update rule test options to flat config

10babca

scagood force-pushed the resolve branch from 68579da to 10babca Compare January 9, 2024 08:55

fix: incorrect env in tests

20c1c9a

aladdin-add merged commit dc9f473 into eslint-community:master Jan 9, 2024
17 checks passed

scagood deleted the resolve branch January 9, 2024 09:42

scagood mentioned this pull request Jan 10, 2024

resolvePaths option works differently with import compared to require #56

Closed

scagood mentioned this pull request Feb 14, 2024

Bug: n/no-missing-imports doesn't work correctly for workspace modules #184

Closed

1 task

scagood linked an issue Feb 14, 2024 that may be closed by this pull request

Bug: n/no-missing-imports doesn't work correctly for workspace modules #184

Closed

1 task

scagood mentioned this pull request Feb 19, 2024

[file-extension-in-import] Dir imports resolve to package/dir.js instead of package/dir/index.js #136

Closed

1 task

github-actions bot mentioned this pull request Feb 27, 2024

chore(release-please): release 17.0.0-4 #193

Closed

sajikix mentioned this pull request Feb 29, 2024

fix(deps): Use eslint-plugin-n instead of eslint-plugin-node cybozu/eslint-config#743

Merged

lkraav mentioned this pull request Apr 4, 2024

16.6.2: can n/no-missing-require allow resolvePaths ['./'] for relative imports? #210

Closed

1 task

voxpelli mentioned this pull request Apr 11, 2024

Bug: no-missing-require incorrectly flagging module as missing #242

Closed

1 task

lholmquist mentioned this pull request May 21, 2024

[Snyk] Upgrade eslint-plugin-n from 16.0.2 to 17.4.0 nodeshift/kube-service-bindings#155

Closed

This was referenced May 29, 2024

[Snyk] Upgrade eslint-plugin-n from 16.0.2 to 17.5.1 nodeshift/kube-service-bindings#157

Closed

[Snyk] Upgrade eslint-plugin-n from 16.0.2 to 17.6.0 nodeshift/kube-service-bindings#160

Closed

hakimio mentioned this pull request Oct 4, 2024

Bug: no-missing-import doesn't use the require algorithm when TS has CJS moduleResolution? #349

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: Start using `enhanced-resolve` to improve ts support #139

feat!: Start using `enhanced-resolve` to improve ts support #139

scagood commented Nov 9, 2023 •

edited

Loading

This comment was marked as outdated.

scagood Nov 26, 2023

aladdin-add Dec 18, 2023

scagood Dec 18, 2023

scagood Nov 26, 2023

This comment was marked as outdated.

aladdin-add commented Dec 15, 2023

scagood commented Dec 15, 2023

aladdin-add Dec 18, 2023

SlyryD left a comment

aladdin-add left a comment

aladdin-add commented Jan 8, 2024

scagood commented Jan 8, 2024

feat!: Start using enhanced-resolve to improve ts support #139

feat!: Start using enhanced-resolve to improve ts support #139

Conversation

scagood commented Nov 9, 2023 • edited Loading

This comment was marked as outdated.

scagood Nov 26, 2023

Choose a reason for hiding this comment

aladdin-add Dec 18, 2023

Choose a reason for hiding this comment

scagood Dec 18, 2023

Choose a reason for hiding this comment

scagood Nov 26, 2023

Choose a reason for hiding this comment

This comment was marked as outdated.

aladdin-add commented Dec 15, 2023

scagood commented Dec 15, 2023

aladdin-add Dec 18, 2023

Choose a reason for hiding this comment

SlyryD left a comment

Choose a reason for hiding this comment

aladdin-add left a comment

Choose a reason for hiding this comment

aladdin-add commented Jan 8, 2024

scagood commented Jan 8, 2024

feat!: Start using `enhanced-resolve` to improve ts support #139

feat!: Start using `enhanced-resolve` to improve ts support #139

scagood commented Nov 9, 2023 •

edited

Loading