fix(always-return): treat process.exit() or process.abort() as an acceptable "return"
#493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cceptable "return"; fixes eslint-community#451
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #493 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 24 -1
Lines 649 660 +11
Branches 250 246 -4
=========================================
+ Hits 649 660 +11 ☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version 6.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Aug 12, 2024
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Aug 20, 2024
##### [v6.6.0](https://github.com/eslint-community/eslint-plugin-promise/releases/tag/v6.6.0) ##### Bug Fixes - **`always-return`:** treat process.exit() or process.abort() as an acceptable "return" ([#493](eslint-community/eslint-plugin-promise#493)) ([f368c5a](eslint-community/eslint-plugin-promise@f368c5a)) ##### Features - add `strict` option to disallow `then` or `catch` following `await` or `yield` ([#494](eslint-community/eslint-plugin-promise#494)) ([fa482cc](eslint-community/eslint-plugin-promise@fa482cc)) ##### [v6.5.1](eslint-community/eslint-plugin-promise@v6.5.0...c011a1a) ##### [v6.5.0](eslint-community/eslint-plugin-promise@v6.4.0...46667d3) ##### [v6.4.0](eslint-community/eslint-plugin-promise@4dfc8a7...ecbce9f) ##### [v6.3.0](eslint-community/eslint-plugin-promise@v6.2.0...4dfc8a7) ##### [v6.2.0](eslint-community/eslint-plugin-promise@v6.1.1...5e4546d)
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Aug 21, 2024
##### [v6.6.0](https://github.com/eslint-community/eslint-plugin-promise/releases/tag/v6.6.0) ##### Bug Fixes - **`always-return`:** treat process.exit() or process.abort() as an acceptable "return" ([#493](eslint-community/eslint-plugin-promise#493)) ([f368c5a](eslint-community/eslint-plugin-promise@f368c5a)) ##### Features - add `strict` option to disallow `then` or `catch` following `await` or `yield` ([#494](eslint-community/eslint-plugin-promise#494)) ([fa482cc](eslint-community/eslint-plugin-promise@fa482cc)) ##### [v6.5.1](eslint-community/eslint-plugin-promise@v6.5.0...c011a1a) ##### [v6.5.0](eslint-community/eslint-plugin-promise@v6.4.0...46667d3) ##### [v6.4.0](eslint-community/eslint-plugin-promise@4dfc8a7...ecbce9f) ##### [v6.3.0](eslint-community/eslint-plugin-promise@v6.2.0...4dfc8a7) ##### [v6.2.0](eslint-community/eslint-plugin-promise@v6.1.1...5e4546d)
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Aug 21, 2024
##### [v6.6.0](https://github.com/eslint-community/eslint-plugin-promise/releases/tag/v6.6.0) ##### Bug Fixes - **`always-return`:** treat process.exit() or process.abort() as an acceptable "return" ([#493](eslint-community/eslint-plugin-promise#493)) ([f368c5a](eslint-community/eslint-plugin-promise@f368c5a)) ##### Features - add `strict` option to disallow `then` or `catch` following `await` or `yield` ([#494](eslint-community/eslint-plugin-promise#494)) ([fa482cc](eslint-community/eslint-plugin-promise@fa482cc)) ##### [v6.5.1](eslint-community/eslint-plugin-promise@v6.5.0...c011a1a) ##### [v6.5.0](eslint-community/eslint-plugin-promise@v6.4.0...46667d3) ##### [v6.4.0](eslint-community/eslint-plugin-promise@4dfc8a7...ecbce9f) ##### [v6.3.0](eslint-community/eslint-plugin-promise@v6.2.0...4dfc8a7) ##### [v6.2.0](eslint-community/eslint-plugin-promise@v6.1.1...5e4546d)
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Aug 21, 2024
##### [v6.6.0](https://github.com/eslint-community/eslint-plugin-promise/releases/tag/v6.6.0) ##### Bug Fixes - **`always-return`:** treat process.exit() or process.abort() as an acceptable "return" ([#493](eslint-community/eslint-plugin-promise#493)) ([f368c5a](eslint-community/eslint-plugin-promise@f368c5a)) ##### Features - add `strict` option to disallow `then` or `catch` following `await` or `yield` ([#494](eslint-community/eslint-plugin-promise#494)) ([fa482cc](eslint-community/eslint-plugin-promise@fa482cc)) ##### [v6.5.1](eslint-community/eslint-plugin-promise@v6.5.0...c011a1a) ##### [v6.5.0](eslint-community/eslint-plugin-promise@v6.4.0...46667d3) ##### [v6.4.0](eslint-community/eslint-plugin-promise@4dfc8a7...ecbce9f) ##### [v6.3.0](eslint-community/eslint-plugin-promise@v6.2.0...4dfc8a7) ##### [v6.2.0](eslint-community/eslint-plugin-promise@v6.1.1...5e4546d)
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Aug 21, 2024
##### [v6.6.0](https://github.com/eslint-community/eslint-plugin-promise/releases/tag/v6.6.0) ##### Bug Fixes - **`always-return`:** treat process.exit() or process.abort() as an acceptable "return" ([#493](eslint-community/eslint-plugin-promise#493)) ([f368c5a](eslint-community/eslint-plugin-promise@f368c5a)) ##### Features - add `strict` option to disallow `then` or `catch` following `await` or `yield` ([#494](eslint-community/eslint-plugin-promise#494)) ([fa482cc](eslint-community/eslint-plugin-promise@fa482cc)) ##### [v6.5.1](eslint-community/eslint-plugin-promise@v6.5.0...c011a1a) ##### [v6.5.0](eslint-community/eslint-plugin-promise@v6.4.0...46667d3) ##### [v6.4.0](eslint-community/eslint-plugin-promise@4dfc8a7...ecbce9f) ##### [v6.3.0](eslint-community/eslint-plugin-promise@v6.2.0...4dfc8a7) ##### [v6.2.0](eslint-community/eslint-plugin-promise@v6.1.1...5e4546d)
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Aug 21, 2024
##### [v6.6.0](https://github.com/eslint-community/eslint-plugin-promise/releases/tag/v6.6.0) ##### Bug Fixes - **`always-return`:** treat process.exit() or process.abort() as an acceptable "return" ([#493](eslint-community/eslint-plugin-promise#493)) ([f368c5a](eslint-community/eslint-plugin-promise@f368c5a)) ##### Features - add `strict` option to disallow `then` or `catch` following `await` or `yield` ([#494](eslint-community/eslint-plugin-promise#494)) ([fa482cc](eslint-community/eslint-plugin-promise@fa482cc)) ##### [v6.5.1](eslint-community/eslint-plugin-promise@v6.5.0...c011a1a) ##### [v6.5.0](eslint-community/eslint-plugin-promise@v6.4.0...46667d3) ##### [v6.4.0](eslint-community/eslint-plugin-promise@4dfc8a7...ecbce9f) ##### [v6.3.0](eslint-community/eslint-plugin-promise@v6.2.0...4dfc8a7) ##### [v6.2.0](eslint-community/eslint-plugin-promise@v6.1.1...5e4546d)
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Aug 21, 2024
##### [v6.6.0](https://github.com/eslint-community/eslint-plugin-promise/releases/tag/v6.6.0) ##### Bug Fixes - **`always-return`:** treat process.exit() or process.abort() as an acceptable "return" ([#493](eslint-community/eslint-plugin-promise#493)) ([f368c5a](eslint-community/eslint-plugin-promise@f368c5a)) ##### Features - add `strict` option to disallow `then` or `catch` following `await` or `yield` ([#494](eslint-community/eslint-plugin-promise#494)) ([fa482cc](eslint-community/eslint-plugin-promise@fa482cc)) ##### [v6.5.1](eslint-community/eslint-plugin-promise@v6.5.0...c011a1a) ##### [v6.5.0](eslint-community/eslint-plugin-promise@v6.4.0...46667d3) ##### [v6.4.0](eslint-community/eslint-plugin-promise@4dfc8a7...ecbce9f) ##### [v6.3.0](eslint-community/eslint-plugin-promise@v6.2.0...4dfc8a7) ##### [v6.2.0](eslint-community/eslint-plugin-promise@v6.1.1...5e4546d)
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Aug 21, 2024
##### [v6.6.0](https://github.com/eslint-community/eslint-plugin-promise/releases/tag/v6.6.0) ##### Bug Fixes - **`always-return`:** treat process.exit() or process.abort() as an acceptable "return" ([#493](eslint-community/eslint-plugin-promise#493)) ([f368c5a](eslint-community/eslint-plugin-promise@f368c5a)) ##### Features - add `strict` option to disallow `then` or `catch` following `await` or `yield` ([#494](eslint-community/eslint-plugin-promise#494)) ([fa482cc](eslint-community/eslint-plugin-promise@fa482cc)) ##### [v6.5.1](eslint-community/eslint-plugin-promise@v6.5.0...c011a1a) ##### [v6.5.0](eslint-community/eslint-plugin-promise@v6.4.0...46667d3) ##### [v6.4.0](eslint-community/eslint-plugin-promise@4dfc8a7...ecbce9f) ##### [v6.3.0](eslint-community/eslint-plugin-promise@v6.2.0...4dfc8a7) ##### [v6.2.0](eslint-community/eslint-plugin-promise@v6.1.1...5e4546d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(
always-return): treat process.exit() or process.abort() as an acceptable "return"Fixes #451
What is the purpose of this pull request?
What changes did you make? (Give an overview)
Don't treat
process.exit()orprocess.abort()as normal call expressions but treat them as returns.