Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Upgrade ESLint to fix type errors #120

Merged
merged 3 commits into from
Sep 25, 2024
Merged

fix: Upgrade ESLint to fix type errors #120

merged 3 commits into from
Sep 25, 2024

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Sep 25, 2024 •
edited
Loading

Prerequisites checklist

What is the purpose of this pull request?

Fix npm run build

What changes did you make? (Give an overview)

  • Upgraded eslint to the latest version to include the types fix.
  • Updated the build script to honor dev dependencies as well.

Related Issues

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Sep 25, 2024
mdjermanovic
mdjermanovic approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit d0c879e into main Sep 25, 2024
14 checks passed
@mdjermanovic mdjermanovic deleted the eslint-up branch September 25, 2024 18:28
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Triage
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nzakas @mdjermanovic