fix: Add 'main' and 'types' entries to package.json #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,6 +3,8 @@ | |||
| "version": "1.0.3", | |||
| "description": "Compatibility utilities for ESLint", | |||
| "type": "module", | |||
| "main": "dist/esm/index.js", | |||
There was a problem hiding this comment.
I noticed that for @eslint/eslintrc alone we are exposing cjs as main and at rest of the places its esm. Is there some reason behind it?
There was a problem hiding this comment.
Yes. @eslint/eslintrc was made primarily for a CJS environment. Going forward, we are targeting primarily ESM. Everything in this repo is ESM-first.
mdjermanovic
approved these changes
Jun 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Add
mainandtypesentries topackage.jsonfiles. Even though we haveexportsspecified, some tools still rely on these old, top-level entries.What changes did you make? (Give an overview)
mainandtypesentries topackage.jsonfiles incompat,config-array, andobject-schema.Related Issues
fixes #46
Is there anything you'd like reviewers to focus on?