feat: Add plugin-kit package #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harish-sethuraman
approved these changes
Aug 8, 2024
aladdin-add
reviewed
Aug 19, 2024
Comment on lines
+7
to
+10
| "dist/esm/index.js", | ||
| "dist/esm/index.d.ts", | ||
| "dist/esm/types.ts", | ||
| "dist/esm/types.d.ts", |
There was a problem hiding this comment.
can be rewritten:
Suggested change
| "dist/esm/index.js", | |
| "dist/esm/index.d.ts", | |
| "dist/esm/types.ts", | |
| "dist/esm/types.d.ts", | |
| "dist/esm/" |
?
There was a problem hiding this comment.
I'm following the convention we have in the other packages. If we want to change that convention, let's do that for all packages in a separate PR.
aladdin-add
previously approved these changes
Aug 19, 2024
| target: object; | ||
| target: unknown; |
There was a problem hiding this comment.
Why this change, isn't this expected to be an object (AST node)?
There was a problem hiding this comment.
unknown forces consumers to specify the type of the object before working with it, which ensures that it's properly typed.
object will just cause squiggles every time you access a property or method that isn't on Object.prototype.
Co-authored-by: Milos Djermanovic <[email protected]>
Co-authored-by: Milos Djermanovic <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Created the new
plugin-kitpackageWhat changes did you make? (Give an overview)
plugin-kitdirectoryConfigCommentParser,VisitNodeStep, andCallMethodStepclassesRelated Issues
fixes #97
Is there anything you'd like reviewers to focus on?
Just starting with the basics for this package. These are some commonalities I've found across the different languages. There will likely be more.
I slightly changed the interface of
ConfigCommentParserto be more generic as the one ineslint/eslintwas very specific to the way Espree represents comments. I tested thisConfigCommentParserin ESLint directly to ensure the new interface works correctly.