Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Standalone ADO creation more verbose/failsafe #131

Open
DiegoPino opened this issue Sep 13, 2021 · 0 comments
Open

Make Standalone ADO creation more verbose/failsafe #131

DiegoPino opened this issue Sep 13, 2021 · 0 comments
Assignees
Labels
bug Something isn't working UI/UX The thing people do when in front of a screen Webform Handler
Milestone

Comments

@DiegoPino
Copy link
Member

What?

Our StrawberryField Harvester Webform Handler can create ADOs outside of a Node create/edit workflow, which in other words means it can work for self deposit forms unattached to a Field Widget. The settings we expose are a bit complex there and we may need to revisit all of them/check if they are all respected but one particular issue is that when you Select "Which States" can trigger an automatic ADO creation (which only works for non anonymous users with ADO creation credentials) and that can also be triggered using the "Create ADO" context menu by any Submission Listing/Admin/Power user on each submission, its not totally clear to an user (nor me!) that the States that can be selected there are not accumulative.

These are all the states a Webform submission can have:

  • STATE_UNSAVED, STATE_DRAFT_CREATED, STATE_DRAFT_UPDATED,
  • STATE_COMPLETED, STATE_UPDATED, STATE_LOCKED, or STATE_CONVERTED depending on the last save operation performed.

Which means if you configure your Webform to "Create ADO" when Webform Submission was Completed, and before actually triggering the Ingest (because the submission was anonymous) the submitter edits/updates the submission, the new state becomes Updated which does not allow any (not even an admin) to override the status and because of that the ADO can not be created until you go back to editing the Handler and adding also Updated as a choice

What I would love is better docs/inline messages in the Harvester Config form. Some cleanup on the code that is there and also better docs for "Create a new revision" which fun! Will also update existing ADOs (or should at least)

There are also Contextual messages missing that should be different for Submitters v/s admins pressing the "Create ADO" button, and also, to be honest, the Create ADO button should be able to bypass some of the automatic restrictions meant really for logged in users submitting which need to be more secure than an admin/forced task.

@aksm @alliomeria we need here some human tests to make sure all the options are working

@DiegoPino DiegoPino added bug Something isn't working UI/UX The thing people do when in front of a screen Webform Handler labels Sep 13, 2021
@DiegoPino DiegoPino added this to the 1.0.0-RC3 milestone Sep 13, 2021
@aksm aksm removed their assignment Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI/UX The thing people do when in front of a screen Webform Handler
Projects
None yet
Development

No branches or pull requests

3 participants