Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a preview limit and respect backend/code set limits for Entity References driven by Solr #174

Open
DiegoPino opened this issue May 21, 2024 · 0 comments
Assignees
Labels
Drupal 10 Gosh. Yes. The number X enhancement New feature or request Search API Anything Solr Driven
Milestone

Comments

@DiegoPino
Copy link
Member

What?

If your Search API server defaults limit (the number of results to get when a view does not define a limit) are very high and because our Search API (solr) driven Entity Reference Display Plugin does show previews (which the DB based does not) we can get time outs.
Also, on other modules we use these type of views as sources for dynamic data (e.g Open API in Format Strawberry field) and for Manifest renderings (list of children) too, so having at least an option to A) respect that choice correctly via a Code set Limit (e.g $this->view->setItemsPerPage($options['limit'])). Entity Reference Displays DO not allow pagers, but at least on the Open API implementations we do allow it to be set. We might want to document that?

I don't want to "set" limit on the preview to a Pager (which can be set, but won't be used by default without our own code) bc it Might give users the impression that it is being enforced by Drupal. Which as you know might not be the case.

@DiegoPino DiegoPino self-assigned this May 21, 2024
@DiegoPino DiegoPino added enhancement New feature or request Search API Anything Solr Driven Drupal 10 Gosh. Yes. The number X labels May 21, 2024
@DiegoPino DiegoPino added this to the 1.4.0 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Drupal 10 Gosh. Yes. The number X enhancement New feature or request Search API Anything Solr Driven
Projects
None yet
Development

No branches or pull requests

1 participant