Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADC for ESP32-S3 #182

Closed
bjoernQ opened this issue Sep 7, 2022 · 1 comment · Fixed by #217
Closed

ADC for ESP32-S3 #182

bjoernQ opened this issue Sep 7, 2022 · 1 comment · Fixed by #217
Assignees
@JurajSadel

Comments

@bjoernQ
Copy link
Contributor

bjoernQ commented Sep 7, 2022

Currently we are missing the ADC implementation for ESP32-S3 because the SVD (and the PAC) doesn't contain it, yet.

Implement it when we have it and in a second step de-duplicate the ADC code (it's currently three similar copies of the same code)
@jessebraham
Copy link
Member

jessebraham commented Oct 18, 2022 •
edited
Loading

The SENS peripheral has been added for the ESP32-S3 in #215, so once that's merged we can move forward with this. I think @JurajSadel was interested in tackling it (please assign yourself to this issue if you are!).

@JurajSadel JurajSadel self-assigned this Oct 19, 2022
@JurajSadel JurajSadel mentioned this issue Oct 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JurajSadel JurajSadel

Labels
None yet
Projects
esp-rs
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ESP32S3: Add ADC support JurajSadel/esp-hal
3 participants
@jessebraham @bjoernQ @JurajSadel