Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize storage of release number from CI scripts #125

Open
georgik opened this issue Jul 22, 2022 · 3 comments
Open

Centralize storage of release number from CI scripts #125

georgik opened this issue Jul 22, 2022 · 3 comments

Comments

@georgik
Copy link
Collaborator

georgik commented Jul 22, 2022

Problem: Rust toolchain version number is stored in 23 files. Each release requires an update of all these files.

Find a way to reduce repeated magic numbers in CI scripts.

@georgik georgik added this to the v1.63 milestone Jul 22, 2022
@SergioGasquez
Copy link
Member

On top of my head, the only option that comes to mind is using Actions Secrets, but it won't show the value if any user would like to know the toolchain version, so I don't really see it as a good option

@SergioGasquez
Copy link
Member

Possible workaround: https://arinco.com.au/blog/github-actions-share-environment-variables-across-workflows/.
It may also be worth mentioning that for every release we also need to update:

One approach could be to generate latest tags. Eg: esp32_v4.4_latest,esp32c3_latest ... The big problem with this approach is that it can unstabilize those repositories.

@SergioGasquez
Copy link
Member

@jessebraham suggested using:

curl --silent https://api.github.com/repos/esp-rs/rust-build/releases | jq -r 'map(select(.prerelease | not)) | first | .tag_name'

Which gets you the latest release name which is NOT a pre-release, the jq query can be updated as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants