Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest_embedded_arduino/: Separated flash settings for each target to fix H2 #220

Merged
merged 1 commit into from
Jul 9, 2023

Conversation

P-R-O-C-H-Y
Copy link
Member

I have separated flash_setting for each SoC, as the H2 cannot flash on default 80MHz.
Tested locally on H2.

Copy link
Member

@hfudev hfudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! the pre-commit check is failing. Could you run pre-commit install locally and run the hook? That should help fix the mixed spaces and tabs issue.

Besides, could you follow the conventional commits while writing the commit messages? The commit message is used for generating the changelog.

For example, the commit message could be fix(arduino): separated flash settings for each target

pytest-embedded-arduino/pytest_embedded_arduino/app.py Outdated Show resolved Hide resolved
@P-R-O-C-H-Y P-R-O-C-H-Y requested a review from hfudev July 7, 2023 12:32
@hfudev
Copy link
Member

hfudev commented Jul 7, 2023

@P-R-O-C-H-Y Mind squash the commits? Thanks! The reason is that the github feature "squash and merge" will make the commit message a bit dirty. ref

The commit message would be

the pull request title + number

- commit 1 message
- commit 2 message

@P-R-O-C-H-Y
Copy link
Member Author

P-R-O-C-H-Y commented Jul 7, 2023

@P-R-O-C-H-Y Mind squash the commits? Thanks! The reason is that the github feature "squash and merge" will make the commit message a bit dirty. ref

The commit message would be

the pull request title + number

- commit 1 message
- commit 2 message

@hfudev Sorry about that. I need to be more careful.. Should Iclose this PR and open new one with the right commit messages?

@P-R-O-C-H-Y
Copy link
Member Author

@hfudev Yeah I meant the squash and merge, but I did not know that it will make the message dirty. I have squashed the commits and force pushed. Should be fine now right? :)

@hfudev hfudev merged commit d7ec268 into espressif:main Jul 9, 2023
5 checks passed
@hfudev
Copy link
Member

hfudev commented Jul 9, 2023

@P-R-O-C-H-Y Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants