local cache for port-target-cache between session (RDT-501) #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfudev
requested changes
Jul 18, 2023
There was a problem hiding this comment.
Thanks for your PR. Overall LGTM.
Instead of upload the local cache every time we run set_port_target_cache or drop_port_target_cache, we may implement init and close for Meta instances. Then we will only load/dump cache once per session.
Besides, please cleanup your commit history a bit. We're using the commit messages to generate the changelog. so it's quite important.
For the PR title, you may write a short summary. Inside the PR description (the first comment), you may add closes #xx. The issue will be closed automatically after this PR is merged.
horw
force-pushed
the
feat/issue_182
branch
3 times, most recently
from
9a709a9
to
7739198
Compare
horw
changed the title
hfudev
reviewed
Jul 19, 2023
hfudev
approved these changes
Jul 19, 2023
|
oh, and one last comment, please follow the contributions guide. The pre-commit check is failing |
github-actions
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement local cache for port-target-cache between session with use shelve.
Change function port_target_cache to yield fixtures type.
closes #182