From 1fc20b6ec6503925d092f19521aa0232688cdacc Mon Sep 17 00:00:00 2001 From: Iwasaki Yudai Date: Mon, 8 Jan 2018 11:21:53 -0800 Subject: [PATCH] mvcc: check null before set FillPercent not to panic Since CreateBucketIfNotExists() can return nil when it gets an error, accessing FilePercent must be done after a nil check, not to cause a panic. --- mvcc/backend/backend.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mvcc/backend/backend.go b/mvcc/backend/backend.go index 42009dd470c7..c0305cf3215e 100644 --- a/mvcc/backend/backend.go +++ b/mvcc/backend/backend.go @@ -373,10 +373,10 @@ func defragdb(odb, tmpdb *bolt.DB, limit int) error { } tmpb, berr := tmptx.CreateBucketIfNotExists(next) - tmpb.FillPercent = 0.9 // for seq write in for each if berr != nil { return berr } + tmpb.FillPercent = 0.9 // for seq write in for each b.ForEach(func(k, v []byte) error { count++