Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: alert for grpc related methods is outdated #8802

Closed
dqminh opened this issue Nov 1, 2017 · 1 comment
Closed

Documentation: alert for grpc related methods is outdated #8802

dqminh opened this issue Nov 1, 2017 · 1 comment
Milestone

Comments

@dqminh
Copy link

dqminh commented Nov 1, 2017

With commit 5e810e3, etcd defers to go-gprc-prometheus to set up prometheus metrics.

The new prometheus metrics are like:

grpc_server_handled_total{grpc_code="OK", grpc_type="unary"}

But alerts refenrence guide is still using old metrics:

IF sum by(grpc_method) (rate(etcd_grpc_requests_failed_total{job="etcd"}[5m]))
  / sum by(grpc_method) (rate(etcd_grpc_total{job="etcd"}[5m])) > 0.01

IF histogram_quantile(0.99, rate(etcd_grpc_unary_requests_duration_seconds_bucket[5m])) > 0.15

We should update the reference guide to use new prometheus metrics instead.

cc @gyuho @brancz

@gyuho
Copy link
Contributor

gyuho commented Nov 27, 2017

Closing via #8879.

@gyuho gyuho closed this as completed Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants