Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcdctl/v3: improve "lease timetolive" output on expired leases #9028

Closed
gyuho opened this issue Dec 18, 2017 · 4 comments
Closed

etcdctl/v3: improve "lease timetolive" output on expired leases #9028

gyuho opened this issue Dec 18, 2017 · 4 comments
Milestone
v3.3.0

Comments

@gyuho
Copy link
Contributor

gyuho commented Dec 18, 2017

https://github.com/coreos/etcd/pull/9017/files#r157349677

Before

LEASE_ID TTL(0s), remaining(-1s)

Should be

LEASE_ID already expired

/cc @xiang90 @hexfusion
@hexfusion
Copy link
Contributor

LEASE_ID already expired

@gyuho, I agree, LEASE_ID TTL(0s), remaining(-1s) is neither helpful or clear.

+1

@hexfusion hexfusion mentioned this issue Dec 18, 2017
Closed
@hexfusion
Copy link
Contributor

@gyuho think this can make 3.3?

@gyuho
Copy link
Contributor Author

gyuho commented Dec 18, 2017

@hexfusion Yes, as long as we document clearly. Do you want to work on this?

@hexfusion
Copy link
Contributor

@gyuho, sure

@gyuho gyuho added this to the v3.3.0 milestone Dec 19, 2017
@gyuho gyuho mentioned this issue Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
v3.3.0
Development

No branches or pull requests
2 participants
@hexfusion @gyuho