e2e test reverse proxy unused functions cleanup #18640
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: henrybear327 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cc @serathius |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files
... and 19 files with indirect coverage changes @@ Coverage Diff @@
## main #18640 +/- ##
==========================================
- Coverage 68.77% 68.76% -0.01%
==========================================
Files 420 420
Lines 35535 35395 -140
==========================================
- Hits 24438 24341 -97
+ Misses 9668 9618 -50
- Partials 1429 1436 +7 Continue to review full report in Codecov by Sentry.
|
|
/retest |
|
/retest |
Part of the patches to fix etcd-io#17737 During the development of etcd-io#17938, we agreed that during the transition to L7 forward proxy, unused features and features targeting L4 reverse proxy will be dropped. This feature falls under the unused feature. Signed-off-by: Chun-Hung Tseng <[email protected]>
Part of the patches to fix etcd-io#17737 During the development of etcd-io#17938, we agreed that during the transition to L7 forward proxy, unused features and features targeting L4 reverse proxy will be dropped. This feature falls under the unused feature. Signed-off-by: Chun-Hung Tseng <[email protected]>
Part of the patches to fix etcd-io#17737 During the development of etcd-io#17938, we agreed that during the transition to L7 forward proxy, unused features and features targeting L4 reverse proxy will be dropped. This feature falls under the unused feature. Also, the initial implementation has a bug: if connections are not created continuously, the latency accept will not work. Consider the following case: a) set latency accept b) put latency accept into effect c) latency accept will start idling the goroutine d) block-wait at accept() - waiting for new connections e) new connection comes in - establish it f) go to c -> as we can see, if the request come every x seconds, where x is larger than the latency accept time we set, we can see that the latency accept has no effect. Signed-off-by: Chun-Hung Tseng <[email protected]>
Part of the patches to fix etcd-io#17737 During the development of etcd-io#17938, we agreed that during the transition to L7 forward proxy, unused features and features targeting L4 reverse proxy will be dropped. This feature falls under the unused feature. Signed-off-by: Chun-Hung Tseng <[email protected]>
henrybear327
force-pushed
the
fix/e2e_blackhole_proxy_code_cleanup
branch
from
2840a56
to
5fb0352
Compare
|
/retest |
1 similar comment
|
/retest |
|
As mentioned in above comment, instead of gutting L4 proxy to make it L7 proxy can you instead fork it? |
May I clarify what you mean by "fork it"? Do you mean that we maintain both L4 and L7 proxies in the codebase? :) |
|
Thanks @henrybear327 for the cleanup. We created so many unused API/methods! The only concern is that they are exported API/Methods, it means that they may be used by other applications (which is unlikely in practice?). |
Part of the patches to fix #17737.
This PR aims to simplify the review load of #18641, by separating all the code cleanup parts first.
During the development of #17938, we agreed that during the transition to an L7 forward proxy, unused features and features targeting the L4 reverse proxy will be dropped.
The functions dropped are
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.