contrib/raftexample: save snapshot to WAL first #8088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbowens LGTM. Thanks! |
Save the snapshot index to the WAL before saving the snapshot to the filesystem. This ensures that we'll only ever call wal.Open with a snapshot that was previously saved to the WAL.
This was referenced Jun 13, 2017
Codecov Report
@@ Coverage Diff @@
## master #8088 +/- ##
=========================================
Coverage ? 76.55%
=========================================
Files ? 342
Lines ? 26568
Branches ? 0
=========================================
Hits ? 20340
Misses ? 4773
Partials ? 1455Continue to review full report at Codecov.
|
iampogo
pushed a commit
to Onyx-Protocol/Onyx
that referenced
this pull request
Jun 13, 2017
Save the snapshot position to the WAL before saving the snapshot data to disk. On boot, we open the WAL at the most recently saved snapshot's position. If we don't save the position to the WAL first, we might open the WAL at a snapshot position that was never saved to the WAL. This is a fix for the 1.2.x release line. See etcd-io/etcd#8082, etcd-io/etcd#8088. Closes #1310
iampogo
pushed a commit
to Onyx-Protocol/Onyx
that referenced
this pull request
Jun 14, 2017
Save the snapshot position to the WAL before saving the snapshot data to disk. On boot, we open the WAL at the most recently saved snapshot's position. If we don't save the position to the WAL first, we might open the WAL at a snapshot position that was never saved to the WAL. See etcd-io/etcd#8082, etcd-io/etcd#8088. Closes #1312
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save the snapshot index to the WAL before saving the snapshot to the
filesystem. This ensures that wal.Open is only ever called with a
snapshot that was previously saved to the WAL.
Fixes #8082.