Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e test #40

Open
ahrtr opened this issue Nov 24, 2022 · 3 comments
Open

Add e2e test #40

ahrtr opened this issue Nov 24, 2022 · 3 comments
Assignees
@Elbehery
Labels
help wanted test

Comments

@ahrtr
Copy link
Member

ahrtr commented Nov 24, 2022

Currently there is only unit test. It would be great if we have an e2e test suite, and it's supposed to be triggered on each PR or commits on master.
@ahrtr ahrtr mentioned this issue May 31, 2023
Open
@Elbehery
Copy link
Member

@ahrtr is there a doc explains what is needed here ?

@ahrtr
Copy link
Member Author

ahrtr commented Mar 28, 2024

@ahrtr is there a doc explains what is needed here ?

There is no doc on this. The ideal is straightforward. We need to start the HTTP server, and tests all RESTful APIs.

gofail/runtime/http.go

Line 39 in 806f13e

func (*httpHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {

@Elbehery
Copy link
Member

ok i can take this 👍🏽

please assign me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Elbehery Elbehery

Labels
help wanted test
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Elbehery @ahrtr