Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version strings #51

Open
etcinit opened this issue Feb 20, 2017 · 4 comments
Open

Update version strings #51

etcinit opened this issue Feb 20, 2017 · 4 comments

Comments

@etcinit
Copy link
Owner

etcinit commented Feb 20, 2017

Figure out a better way of including the version in the binary. Currently, it is being hardcoded in a couple of places.

@perrohunter
Copy link

perhaps related to this, im not sure, is that the latest release 3.0.0-beta1 returns as if it was version 2.4.0 but the bot announces itself as if it was version 3

curl http://localhost:8085/
{"messages":["Welcome to the Phabulous API"],"status":"success","version":"2.4.0-beta1"}

@etcinit
Copy link
Owner Author

etcinit commented Feb 21, 2017

Yep. Looking to find a simple way to have it centralized in one place.

@holmboe
Copy link

holmboe commented Apr 23, 2018

I am also affected by this with the v3.0.0-beta3 tag on quay.io.

@holmboe
Copy link

holmboe commented Apr 23, 2018

It is better to hardcode something like UNKNOWN in front.go, no? If tit is not guaranteed to be correct and updated then I suggest that it would be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants