Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for BIP39 mnemonics #334

Closed
iamdefinitelyahuman opened this issue Jan 19, 2020 · 4 comments · Fixed by #585
Closed

Add support for BIP39 mnemonics #334

iamdefinitelyahuman opened this issue Jan 19, 2020 · 4 comments · Fixed by #585
Labels
enhancement New feature or request priority Should be included in next release

Comments

@iamdefinitelyahuman
Copy link
Member

iamdefinitelyahuman commented Jan 19, 2020 •
edited
Loading

Overview

Brownie should support BIP39 seed phrases and BIP32 HD wallets.

Specification

  • Use Trezor's mnemonic library for the implementation - it is widely used and trusted by the community.
  • Accounts.mnemonic() should generate a LocalAccount from a mnemonic (this was removed in 616122f)
  • In the CLI it should be possible to add a new account using a mnemonic, either through brownie accounts new or another similar command.
  • A mnemonic should be displayed when generating an account via Accounts.new() or brownie accounts generate in the CLI
  • Mnemonics must be compatible with metamask and ganache - should check their test cases and run Brownie against identical ones.
@iamdefinitelyahuman iamdefinitelyahuman added the enhancement New feature or request label Jan 19, 2020
This was referenced Jan 19, 2020
Closed
Closed
Closed
@iamdefinitelyahuman iamdefinitelyahuman added this to the Brownie 1.5.0 milestone Jan 19, 2020
@fubuloubu
Copy link
Contributor

Also, consider upstreaming this to eth-account

@iamdefinitelyahuman iamdefinitelyahuman removed this from the Brownie 1.5.0 milestone Jan 20, 2020
@iamdefinitelyahuman
Copy link
Member Author

@fubuloubu see efdevcon/pretix-eth-payment-plugin#64 (comment) re: status of this in eth-account

@iamdefinitelyahuman iamdefinitelyahuman added this to the Brownie 1.7.0 milestone Apr 5, 2020
@iamdefinitelyahuman
Copy link
Member Author

Update on this: ethereum/eth-account#87 was included in eth-account v0.5.0. Now waiting for a new version of web3.py that bumps the eth-account version. Then this can functionality can finally be added!

@iamdefinitelyahuman iamdefinitelyahuman removed this from the Brownie 1.7.0 milestone Apr 8, 2020
@iamdefinitelyahuman
Copy link
Member Author

web3py v5.9.0 is released! no more blockers on this :)

@iamdefinitelyahuman iamdefinitelyahuman added the priority Should be included in next release label Apr 30, 2020
@iamdefinitelyahuman iamdefinitelyahuman added this to the Brownie 1.9.0 milestone May 31, 2020
@iamdefinitelyahuman iamdefinitelyahuman mentioned this issue May 31, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request priority Should be included in next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support for seed phrases eth-brownie/brownie
2 participants
@fubuloubu @iamdefinitelyahuman