-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call for Input: Accidental function in ERC-223 #283
Comments
I don't see a problem with this. Like @Pandapip1 says, removing this function is backwards compatible and this definitely looks like a mistake on the authors' part. merge |
+1 for me. Will also assist @Dexaran if he wants to seperate this into its own standard as-is. |
I thought the ERC-223 is... final? |
i am fine removing something which accidentally got by and already notifies in EIP that implementations shouldn't depend on it |
I am fine to have it removed if it's accidental inclusion provided it's still very recently finalized. And let's avoid this next time together. |
cut-and-dry example of an "errata" edit-- not a normative change, doesn't break anything normative, grounded in the history of the PR |
Will we merge ethereum/EIPs#7856? See that pull request for details.
tl;dr function was removed from spec then later accidentally re-added.
The text was updated successfully, but these errors were encountered: