Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call for Input: Change Author Username in ERC-6672 #331

Closed
SamWilsn opened this issue Apr 3, 2024 · 11 comments
Closed

Call for Input: Change Author Username in ERC-6672 #331

SamWilsn opened this issue Apr 3, 2024 · 11 comments

Comments

@SamWilsn
Copy link
Collaborator

SamWilsn commented Apr 3, 2024

Call for Input

Decision

Do we merge https://github.com/ethereum/ERCs/pull/285/files ?

If Affirmed

ERC-6672's author list is updated.

If Rejected No change.
Method Rough Consensus
Deadline May 2nd, 2024

Background

@SamWilsn has verified the identity of the author by email.

@SamWilsn
Copy link
Collaborator Author

SamWilsn commented Apr 3, 2024

I am in favour of merging this pull request.

@SamWilsn
Copy link
Collaborator Author

SamWilsn commented Apr 3, 2024

@xinbenlv has also expressed support on the pull request.

@abcoathup
Copy link

I'm against (I don't have a vote).
I'm generally against any changes to final EIPs. We should have a wiki page for each EIP where errata/updates can be added.

For GitHub username changes, at the very least I would want a repeatable process.
Ideally a combination of both:

  1. multiple authors of an EIP approve the GitHub name change
  2. GitHub evidence that the name was changed by the author themselves

@g11tech
Copy link

g11tech commented Apr 3, 2024

i guess we would want to reflect the new names but as @abcoathup mentions, its better done by some repeatable process

@SamWilsn
Copy link
Collaborator Author

SamWilsn commented Apr 3, 2024

Is "open a Call for Input" an insufficiently repeatable process?

@xinbenlv
Copy link

xinbenlv commented Apr 3, 2024

my stance:

  • Authors shall hold the power to update name or contact info, not editors. Editors merely facilitate authors to update it when tooling hasnt support author do it on their own or solo author.
  • What is considered a prerequisite to update username shall be consistent and transparent ("At editor discretion" seems too abstract)

If that needs to be in errata instead of the preemble it's fine to me.

I am fine either way.

Call for input every time seems to be too slow and requires unnecessary consensus of editors which is scarce resource, but I am ok if everyone wants to do call for input.

@lightclient
Copy link

I approve

@abcoathup
Copy link

@SamWilsn

Is "open a Call for Input" an insufficiently repeatable process?

Call for input is too slow, takes up too much governance resources and should be for exceptions.
If the agreement is that username changes will be allowed under certain conditions (which appears to be the consensus) then any editor can merge when the conditions are met. e.g. >50% of authors approve

@SamWilsn
Copy link
Collaborator Author

SamWilsn commented Apr 4, 2024

Call for input is too slow

If editors responded more quickly/reliably, this wouldn't be an issue. The deadline is only there to keep things moving when some editors don't participate.

Is changing usernames on a final proposal a time sensitive issue?

If the agreement is that username changes will be allowed under certain conditions (which appears to be the consensus) then any editor can merge when the conditions are met. e.g. >50% of authors approve

This comes up rarely enough that I don't think we need a formal process. We're like... six people. Just ask one of us to make the change, and we can sort it out.

@poojaranjan poojaranjan mentioned this issue Apr 10, 2024
16 tasks
@xinbenlv
Copy link

Call for input every time seems to be too slow and requires unnecessary consensus of editors which is scarce resource, but I am ok if everyone wants to do call for input.

For the context of this issue, I am in favor while with a different reason

@poojaranjan poojaranjan mentioned this issue Apr 11, 2024
19 tasks
@SamWilsn
Copy link
Collaborator Author

The general consensus seems to be to merge this pull request.

@poojaranjan poojaranjan mentioned this issue May 22, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants