This repository has been archived by the owner on Feb 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 37
[feature] Automerge withdrawn EIPs #18
Comments
cc @MicahZoltu |
Yes. If an author approves a withdraw, it should auto-merge. I think it should also auto-merge if an editor approves, that way if we receive approval in an incorrect form (like an author just giving a thumbs up or a PR comment) we can push things through for them without having to override. |
btw I won't add this to my workload until it's a [feature] / concensus |
There isn't likely to be anyone else who chimes in on the issue. @pooja may have some thoughts, but none of the other editors actively participate in these kinds of discussions. |
alita-moore
changed the title
[question] Should bot automerge withdrawn EIPs?
[feature] Automerge withdrawn EIPs?
Sep 27, 2021
14 tasks
alita-moore
changed the title
[feature] Automerge withdrawn EIPs?
[feature] Automerge withdrawn EIPs
Sep 27, 2021
13 tasks
11 tasks
This will also be accomplished via df5b0b3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Intuitively, it feels like if the author of an EIP elects to withdraw the EIP, it shouldn't need editor approval.
See here for example:
ethereum/EIPs#4189
The text was updated successfully, but these errors were encountered: