Skip to content
This repository has been archived by the owner on Feb 9, 2023. It is now read-only.

[feature] Automerge withdrawn EIPs #18

Closed
lightclient opened this issue Sep 25, 2021 · 5 comments
Closed

[feature] Automerge withdrawn EIPs #18

lightclient opened this issue Sep 25, 2021 · 5 comments

Comments

@lightclient
Copy link
Member

Intuitively, it feels like if the author of an EIP elects to withdraw the EIP, it shouldn't need editor approval.

See here for example:
ethereum/EIPs#4189

@alita-moore
Copy link
Contributor

cc @MicahZoltu

@MicahZoltu
Copy link
Contributor

Yes. If an author approves a withdraw, it should auto-merge. I think it should also auto-merge if an editor approves, that way if we receive approval in an incorrect form (like an author just giving a thumbs up or a PR comment) we can push things through for them without having to override.

@alita-moore
Copy link
Contributor

alita-moore commented Sep 26, 2021

btw I won't add this to my workload until it's a [feature] / concensus

@MicahZoltu
Copy link
Contributor

There isn't likely to be anyone else who chimes in on the issue. @pooja may have some thoughts, but none of the other editors actively participate in these kinds of discussions.

@alita-moore alita-moore changed the title [question] Should bot automerge withdrawn EIPs? [feature] Automerge withdrawn EIPs? Sep 27, 2021
@alita-moore alita-moore changed the title [feature] Automerge withdrawn EIPs? [feature] Automerge withdrawn EIPs Sep 27, 2021
@alita-moore
Copy link
Contributor

This will also be accomplished via df5b0b3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@MicahZoltu @lightclient @alita-moore and others