Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errata'd EIPs #5652

Closed
Pandapip1 opened this issue Sep 14, 2022 · 19 comments
Closed

Errata'd EIPs #5652

Pandapip1 opened this issue Sep 14, 2022 · 19 comments
Labels
e-consensus Waiting on editor consensus enhancement r-ci Relates to the CI r-eips Relates to the formatting or another aspect of EIPs r-process Relates to an EIP Process w-stale Waiting on activity

Comments

@Pandapip1
Copy link
Member

Proposed Change

I propose that with the approval of an original non-errata'd Final EIP's author, a new EIP can be created with the EIP "number" <original-eip-number>-e<number-erratas>, where <original-eip-number> is the original Final EIP's number, and <number-erratas> is a number that starts at 1 and increments by 1 every time an errata EIP for the given original EIP number reaches final, withdrawn, or stagnant.

So, instead of modifying EIP-721, a new EIP would be created with the number 721-e1, referenced as "EIP-721-e1".

@Pandapip1 Pandapip1 added enhancement r-ci Relates to the CI r-process Relates to an EIP Process r-eips Relates to the formatting or another aspect of EIPs e-consensus Waiting on editor consensus labels Sep 14, 2022
@SamWilsn
Copy link
Contributor

If we decide the changes are errata, we can change a final EIP (and git keeps the history.)

If we decide it isn't errata, it's a new EIP and I think it deserves its own number.


I'm also concerned that complicating the EIP number namespace will just make things worse.

@Pandapip1
Copy link
Member Author

If we decide the changes are errata, we can change a final EIP (and git keeps the history.)
If we decide it isn't errata, it's a new EIP and I think it deserves its own number.

The point here is that you might have something like EIP-712 where there are valid arguments for and against "it's an errata" vs "it's actually a major change." Skipping the discussion and letting the authors make that judgment call saves EIP editor brain bandwidth.

@fermentfan
Copy link
Contributor

I love the idea. There will always be a chance for small formal errors in EIPs as we're all humans after all and EIP numbers are already being recognized in the heads of the people. Due to this a sudden change of the number for a new version of a well known standard might be damaging the communication.

@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Jan 26, 2023
@Pandapip1
Copy link
Member Author

Dismissing stale bot.

@github-actions github-actions bot removed the w-stale Waiting on activity label Jan 27, 2023
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Feb 3, 2023
@Pandapip1
Copy link
Member Author

Dismissing stale bot.

@github-actions github-actions bot removed the w-stale Waiting on activity label Feb 5, 2023
@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Feb 13, 2023
@Pandapip1
Copy link
Member Author

Dismissing stale bot.

@github-actions github-actions bot removed the w-stale Waiting on activity label Feb 14, 2023
@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Feb 21, 2023
@Pandapip1
Copy link
Member Author

Dismissing stale bot.

@github-actions github-actions bot removed the w-stale Waiting on activity label Feb 23, 2023
@github-actions
Copy link

github-actions bot commented Mar 2, 2023

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Mar 2, 2023
@Pandapip1
Copy link
Member Author

Dismissing stale bot

@github-actions github-actions bot removed the w-stale Waiting on activity label Mar 4, 2023
@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Mar 12, 2023
@Pandapip1
Copy link
Member Author

Dismissing stale bot

@github-actions github-actions bot removed the w-stale Waiting on activity label Mar 15, 2023
@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Mar 23, 2023
@Pandapip1
Copy link
Member Author

Bump.

@github-actions github-actions bot removed the w-stale Waiting on activity label Mar 30, 2023
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Apr 7, 2023
@github-actions
Copy link

This issue was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e-consensus Waiting on editor consensus enhancement r-ci Relates to the CI r-eips Relates to the formatting or another aspect of EIPs r-process Relates to an EIP Process w-stale Waiting on activity
Projects
None yet
Development

No branches or pull requests

4 participants
@fermentfan @Pandapip1 @SamWilsn and others