updated implementation details in EIP-712 #3763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All tests passed; auto-merging... |
recmo
approved these changes
Sep 27, 2021
|
|
||
| * `keccak256` struct hashing | ||
|
|
||
| While the `keccak256` function in Solidity cannot be invoked directly on structs, the introduction of `abi.encode` gives a sufficient and well-accepted avenue to hashing structs. |
There was a problem hiding this comment.
And when gas cost matters, dropping to assembly is always an option.
There was a problem hiding this comment.
Thanks for taking a look! Do you think this needs to be included in the text, or should it be left as is?
|
CI failing on:
|
auto-merge was automatically disabled
October 3, 2021 13:34
Head branch was pushed to by a user without write access
drortirosh
pushed a commit
to drortirosh/EIPs
that referenced
this pull request
Oct 3, 2021
* updated implementation details in EIP-712 * fixed typos
PhABC
pushed a commit
to PhABC/EIPs
that referenced
this pull request
Jan 25, 2022
* updated implementation details in EIP-712 * fixed typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.