Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create voting_period and seal off vote data #158

Open
djrtwo opened this issue May 30, 2018 · 1 comment
Open

Create voting_period and seal off vote data #158

djrtwo opened this issue May 30, 2018 · 1 comment
Assignees

Comments

@djrtwo
Copy link
Contributor

djrtwo commented May 30, 2018

Issue

Note: this update will be paired with a corresponding update to EIP 1011.

There are issues with the assumed one-way independence between votes and normal block transactions. We aim to create a two-way independence between votes and normal block txs to ensure paralellizability of vote txs and to remove the ordering constraint on vote txs (votes will no longer have to be at the end of the block).

We do this by

  • creating a voting_period in which only votes can modify state.
  • hiding the state that votes are modifying and only update publicly readable state after the voting period, during initialize_epoch.

The new hidden vote related vars will be readable via ENTRY_ADDRESS so that they are still accessible off chain to interested parties such as Validators.

voting_period degrades UX for validator clients due to the requirement of timing non-voting actions to fall not in_voting_period, but this is a necessary trade off to achieve vote parallelization.

Proposed Implementation

  • Add contract var VOTE_START_BLOCK (greater than 0 and less than EPOCH_LENGTH, suggested 13)
  • Add contract var ENTRY_ADDRESS (suggested 0x1)
  • Create a public method in_voting_period() that uses VOTE_START_BLOCK
  • Add assertion to state-modifying methods other than vote -- assert not self.in_voting_period()
  • Add assertion to vote -- assert self.in_voting_period()
  • Modify vote so that it is modifying a hidden set of variables related to the current epoch. These variables can only be read by ENTRY_ADDRESS.
  • initialize_epoch updates public vars from the hidden set of vote variables. Including paying vote inclusion rewards to miners
  • move validators__deposit to a separate map. This map is only readable outside of the voting period OR any time by ENTRY_ADDRESS

in_voting_period() is something like the following:

def in_voting_period() -> bool:
    return block.number % self.EPOCH_LENGTH >= self.VOTE_START_BLOCK
@djrtwo
Copy link
Contributor Author

djrtwo commented Jun 6, 2018

This should solve #117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant