Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests take too long #163

Open
djrtwo opened this issue Jun 4, 2018 · 0 comments
Open

Tests take too long #163

djrtwo opened this issue Jun 4, 2018 · 0 comments

Comments

@djrtwo
Copy link
Contributor

djrtwo commented Jun 4, 2018

Issue

Tests take too long. I believe this has to do primarily with two factors

  • Cannot reuse setup in most cases so have to scrap chain and redeploy all contracts
  • Length of epochs and dynasties that the tests have to churn through

The second is probably the main one. I would not try to optimize the first until the second has been fully optimized.

Proposed implementation

  • Reduce the base casper constants as small as possible while still capturing the spirit of the tests
  • Be careful. The default of eth-tester is to mine a block every time a tx is submit. If you keep this enabled and reduce the constant sizes too small, you might get weird behavior. For example: if you have num_validators > EPOCH_LENGTH and there is only one validator vote per block, you won't be able to fit all the validator votes into a single epoch!
  • Don't make the tests too complex in terms of readability or writability in favor of time reduction.
  • Examine any other bottlenecks and optimize if it's worth it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant