Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce accessibility modifiers as much as possible #1151

Closed
ralexstokes opened this issue May 6, 2019 · 2 comments
Closed

Reduce accessibility modifiers as much as possible #1151

ralexstokes opened this issue May 6, 2019 · 2 comments

Comments

@ralexstokes
Copy link
Member

Some functions in the deposit contract are marked @public when they have no reason to be (other than implementation details of the vyper stack, i.e. they are easier to test when marked @public).

I suggest in the spirit of keeping this contract as simple and small as possible, we reduce the size of the public API by remove the @public decorators where we can.

At the moment that is:

@public
@constant
def to_little_endian_64(value: uint256) -> bytes[8]:

assuming we also address #34.

@hwwhww hwwhww transferred this issue from ethereum/deposit_contract Jun 8, 2019
@JustinDrake
Copy link
Collaborator

As you mention, removing @public on to_little_endian_64 breaks the tests.

Please open a PR ASAP if you feel strongly about this :) It will be harder to make changes after spec freeze, and after formal verification of the deposit contract.

@JustinDrake
Copy link
Collaborator

Fixed in #1152 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants