You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some functions in the deposit contract are marked @public when they have no reason to be (other than implementation details of the vyper stack, i.e. they are easier to test when marked @public).
I suggest in the spirit of keeping this contract as simple and small as possible, we reduce the size of the public API by remove the @public decorators where we can.
As you mention, removing @public on to_little_endian_64 breaks the tests.
Please open a PR ASAP if you feel strongly about this :) It will be harder to make changes after spec freeze, and after formal verification of the deposit contract.
Some functions in the deposit contract are marked
@public
when they have no reason to be (other than implementation details of the vyper stack, i.e. they are easier to test when marked@public
).I suggest in the spirit of keeping this contract as simple and small as possible, we reduce the size of the public API by remove the
@public
decorators where we can.At the moment that is:
assuming we also address #34.
The text was updated successfully, but these errors were encountered: