Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer the version field in metadata to the spec version #27

Closed
ChihChengLiang opened this issue Mar 15, 2019 · 5 comments
Closed

Refer the version field in metadata to the spec version #27

ChihChengLiang opened this issue Mar 15, 2019 · 5 comments

Comments

@ChihChengLiang
Copy link
Collaborator

There's a version field in the metadata. Not sure if it's meaningful to assign a version number to every test suite. However, it's useful to track what spec version the test suite is implemented.

Before:

metadata = {
        'title': 'Shuffling Algorithm Tests 1',
        'summary': 'Test vectors for validator shuffling with different validator\'s activity status.'
                   ' Note: only relevant validator fields are defined.',
        'test_suite': 'shuffle',
        'fork': 'tchaikovsky',
        'version': 1.0
    }

After:

metadata = {
        'title': 'Shuffling Algorithm Tests 1',
        'summary': 'Test vectors for validator shuffling with different validator\'s activity status.'
                   ' Note: only relevant validator fields are defined.',
        'test_suite': 'shuffle',
        'fork': 'tchaikovsky',
        'spec_version': 0.4.0
    }
@jannikluhn
Copy link
Collaborator

Should we maybe just drop version and use fork instead? Btw, what exactly does tchaikovsky refer to right now?

@ChihChengLiang
Copy link
Collaborator Author

Do you mean write spec version in the field fork?
I'm also curious about tchaikovsky too 😂

@jannikluhn
Copy link
Collaborator

yes, maybe with some prefix, like phase0-0.5.0

@djrtwo
Copy link
Contributor

djrtwo commented Mar 15, 2019

tchaikovsky was a stub from the original sample format :)

The distinction between version and fork is probably not really meaningful. I believe using just fork makes sense.

@ChihChengLiang
Copy link
Collaborator Author

ChihChengLiang commented Mar 16, 2019

Add #28 and ethereum/eth2.0-tests#25 to specify fork:phase0-0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants