Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: return chainId for legacy txs using EIP-155 signature + don't accept chainid in TransactionArgs #25141

Closed
lightclient opened this issue Jun 21, 2022 · 1 comment · Fixed by #25155 or #25157
Closed

rpc: return chainId for legacy txs using EIP-155 signature + don't accept chainid in TransactionArgs #25141

lightclient opened this issue Jun 21, 2022 · 1 comment · Fixed by #25155 or #25157
Labels
type:bug

Comments

@lightclient
Copy link
Member

This issue came up in a discussion here: ethereum/execution-apis#239

I think the correct approach is to set chainId for legacy txs that take advantage of EIP-155. If we want to take it a step farther, we could say that chainId = 0 refers to a tx valid on any chain. This is essentially what the tx.ChainId() method does.

--

Additionally, accepting chainId in TransactionArgs seems superfluous. If chainId doesn't match with the client it should probably be an error anyways. Seems simpler to just remove it altogether.
@lightclient
Copy link
Member Author

lightclient commented Jun 23, 2022 •
edited
Loading

So I'll make sure EIP-155 legacy txs also return chainId over RPC and that if chainId in tx args does not match the local chain id we will always error.

This was referenced Jun 23, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
No milestone
2 participants
@lightclient and others