Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile errors with golang 1.18. Need to stop using atomic.Pointer or change README.md so minimal golang required is updated. Please note requiring golang upgrade would "break" Ubuntu LTS. #26789

Closed
J-A-M-E-5 opened this issue Mar 2, 2023 · 2 comments · Fixed by #26803
Closed

Compile errors with golang 1.18. Need to stop using atomic.Pointer or change README.md so minimal golang required is updated. Please note requiring golang upgrade would "break" Ubuntu LTS. #26789

J-A-M-E-5 opened this issue Mar 2, 2023 · 2 comments · Fixed by #26803
Labels
type:bug

Comments

@J-A-M-E-5
Copy link

J-A-M-E-5 commented Mar 2, 2023 •
edited
Loading

Compile error:-
core/blockchain.go:202:27: undefined: atomic.Pointer

Same thing happened a few weeks ago here: #26679

Users of Ubuntu 22.04 LTS now have to compile a new version of go as the repo version is 1.18. Or these changes need to be backed out which is what happened 2 weeks ago. Can your automated builds not use 1.18 to spot these errors, until you decide to no longer support 1.18?
@J-A-M-E-5 J-A-M-E-5 changed the title Compile errors with golang 1.19. Need to stop using atomic.Pointer or change README.md so minimal golang required is updated. Please note requiring golang upgrade would "break" Ubuntu LTS. Compile errors with golang 1.18. Need to stop using atomic.Pointer or change README.md so minimal golang required is updated. Please note requiring golang upgrade would "break" Ubuntu LTS. Mar 2, 2023
@J-A-M-E-5
Copy link
Author

J-A-M-E-5 commented Mar 2, 2023 •
edited
Loading

This appears to be the change that broke it: #26777

Looking more closely at change and comments @karalabe is aware that this breaks go1.18 and comments that effectively go1.18 is no longer supported. Therefor I suggest README.md is changed to reflect this.

@karalabe karalabe mentioned this issue Mar 3, 2023
Merged
@karalabe
Copy link
Member

karalabe commented Mar 3, 2023

Bumped the minimum version to Go 1.19 so there's no more confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

README, go.mod, event, internal/version: bump min Go to 1.19 karalabe/go-ethereum
2 participants
@karalabe @J-A-M-E-5