Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confusing comment in blob priority explanation #28977

Closed
bkellerman opened this issue Feb 12, 2024 · 2 comments
Closed

confusing comment in blob priority explanation #28977

bkellerman opened this issue Feb 12, 2024 · 2 comments

Comments

@bkellerman
Copy link
Contributor

bkellerman commented Feb 12, 2024

Is delta-basefee supposed to be a difference(subtraction operation) or a is -basefee a qualifier of the type of delta?

If it's a qualifier, this comment is confusing as it appears to be a subtraction. I don't see a subtraction in the code. Maybe use an underscore?

priority = min(delta-basefee, delta-blobfee)

// priority = min(delta-basefee, delta-blobfee)

@bkellerman bkellerman changed the title Incorrect comment for blob priority comments? confusing comment in blob priority explanation Feb 12, 2024
@ababyprogrammer
Copy link

This is my question, too.

@bkellerman
Copy link
Contributor Author

PR #28981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants