Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that witness costs are charged per-tx and not per-block #137

Closed
gballet opened this issue Nov 30, 2021 · 2 comments
Closed

Ensure that witness costs are charged per-tx and not per-block #137

gballet opened this issue Nov 30, 2021 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@gballet
Copy link
Member

gballet commented Nov 30, 2021

The EIP definitions have changed, and the witness costs have to be charged per-transaction. We need to ensure that this is what the code does, because the old behavior was to charge said costs per-block.

@gballet gballet added the question Further information is requested label Nov 30, 2021
@jwasinger
Copy link
Collaborator

In gballet/go-ethereum#37, I'm fairly sure this is the case. The AccessWitness used is per-TxContext (which as the name implies, only exists for the lifetime of a transaction).

@gballet gballet self-assigned this Jan 19, 2022
@gballet
Copy link
Member Author

gballet commented Aug 28, 2024

Long fixed. Closing.

@gballet gballet closed this as completed Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants