Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add build.os config to rtd #34

Merged
merged 1 commit into from
Aug 31, 2023
Merged

add build.os config to rtd #34

merged 1 commit into from
Aug 31, 2023

Conversation

pacrob
Copy link
Contributor

@pacrob pacrob commented Aug 31, 2023 •
edited
Loading

What was wrong?

ReadTheDocs will soon start requiring build.os config

How was it fixed?

Added to readthedocs.yml

Todo:

  • Clean up commit history

  • Add or update documentation related to these changes

  • Add entry to the release notes

Cute Animal Picture

image

@pacrob pacrob requested review from reedsa and fselmo August 31, 2023 21:41
fselmo
fselmo approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for adding the rtd docs build to the repo 👍🏼

@pacrob pacrob merged commit 8fb34eb into ethereum:master Aug 31, 2023
1 check passed
@pacrob pacrob deleted the rtd-build-os branch August 31, 2023 21:55
pacrob added a commit to pacrob/hexbytes that referenced this pull request Sep 28, 2023
@pacrob
Various template default updates (#74)
ffd6ad8 
* bump versions in dependencies and ci builds

* move tox to [dev] per issue ethereum#34

* move RTD deps pointer into .readthedocs.yml

* unpin flake8 add flake8-bugbear to lint deps
pacrob added a commit to pacrob/hexbytes that referenced this pull request Nov 27, 2023
@pacrob
Various template default updates (#74)
6c48bfe 
* bump versions in dependencies and ci builds

* move tox to [dev] per issue ethereum#34

* move RTD deps pointer into .readthedocs.yml

* unpin flake8 add flake8-bugbear to lint deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reedsa reedsa reedsa approved these changes

@fselmo fselmo fselmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pacrob @reedsa @fselmo