Properly fill genesis_data defaults
#215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacrob
force-pushed
the
test-filling-defaults-with-models
branch
from
1cff0fc
to
665e946
Compare
kclowes
reviewed
Jun 5, 2024
| if genesis_data.get("config"): | ||
| try: | ||
| genesis_data_config_filled = GenesisDataConfig(**genesis_data["config"]) | ||
| except ValidationError as e: |
There was a problem hiding this comment.
Do you think it's worth adding a test for hitting the error conditions?
pacrob
force-pushed
the
test-filling-defaults-with-models
branch
from
99bfa6c
to
68ee2b2
Compare
fselmo
approved these changes
Jun 6, 2024
geth/utils/validation.py
Outdated
| @@ -135,13 +145,37 @@ def validate_genesis_data(genesis_data: GenesisDataTypedDict) -> bool: | |||
| raise PyGethValueError( | |||
| f"error while validating genesis_data config field: {e}" | |||
| ) | |||
|
|
|||
| return True | |||
There was a problem hiding this comment.
nit: I think we can probably leave this out and return None in the signature. Generally I don't expect validation methods to return anything, except raise if appropriate.
pacrob
force-pushed
the
test-filling-defaults-with-models
branch
from
03a8386
to
294691c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Filling
geth_kwargsdefaults by just creating a model from the dict works fine because its only member that is a dict (suffix_kwargs) defaults toNone.genesis_data["config"]does have default values, so just creating aGenesisDatamodel from the dict does not fill the sub-dict properly.How was it fixed?
Added a
fill_default_genesis_datafunction and test.Todo:
Cute Animal Picture