Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing items from genesis #221

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Conversation

antazoey
Copy link
Contributor

@antazoey antazoey commented Jun 27, 2024

What was wrong?

Related to Issue #220
Closes #220

mostly opening to show what I had to do to get it to work in Ape!

How was it fixed?

add fields

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

◡̈ <--- it's an ape!

@kclowes
Copy link
Contributor

kclowes commented Jun 27, 2024

Thanks for the PR! I added a few more that I noticed were missing.

@kclowes kclowes requested review from pacrob, fselmo and reedsa June 27, 2024 20:51
@kclowes
Copy link
Contributor

kclowes commented Jun 27, 2024

@antazoey I also changed mixhash -> mixHash to match geth, let me know if that throws you off and I'll change it back!

@kclowes kclowes marked this pull request as ready for review June 27, 2024 20:54
@antazoey
Copy link
Contributor Author

@antazoey I also changed mixhash -> mixHash to match geth, let me know if that throws you off and I'll change it back!

I had it that way before. So that works!

Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kclowes kclowes merged commit bf47dac into ethereum:main Jun 28, 2024
38 checks passed
@antazoey antazoey deleted the feat/chain-id branch June 28, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to set chainId in geth --dev genesis config
3 participants