Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENS support in address field #90

Closed
ligi opened this issue Mar 17, 2020 · 6 comments
Closed

ENS support in address field #90

ligi opened this issue Mar 17, 2020 · 6 comments
Assignees

Comments

@ligi
Copy link
Member

ligi commented Mar 17, 2020

Great suggestion on twitter: https://twitter.com/gh1dra/status/1239962423341322241

View in Huly HI-427

@corydickson
Copy link

Give me a few days and I'll pick this up

@corydickson
Copy link

Strange times ahead :)

@corydickson
Copy link

As a user I would like to be able to enter an ENS address and it will resolve the associated on-chain ethereum address with its source code and metadata. If such an entry already exists in the repository notify the user, otherwise prompt the user to upload said files to IPFS and verify.

To achieve this we will need to interact with the ENS resolver contract on a given chain. This mapping could be maintained in the front-end. Once we have the address, check it's runtime bytecode against entries in the address-db, if the value at a given key match then it already exists inside the repository.

A consideration is that this will only work for TLD if my understanding is correct? Furthermore is it necessary to have the user upload these files, or would a better approach is to leverage this EIP, ensuring that the retrieved ABI hash is already pinned to IPFS. I believe the source code would still need to be provided though...

I'll get started mocking up the UI, hopefully I'm thinking about this the right way

@ligi
Copy link
Member Author

ligi commented Mar 27, 2020

ah good that we talked about it ;-)
I understood your idea differently. With ENS support I thought you mean instead of entering an hex address in the form you would enter the ENS address of the contract.
Actually I was not even aware of EIP-205. But before going this route I would actually check if there are contracts out there that leverage this EIP - have the gut feeling that it is not.
I think we should split these issues a bit and keep this issue around "ENS support in address field" - meaning if the user enters something that does not start with 0x we will try to resolve it via ENS instead of telling the user that it is not an valid address.
But feel free to open issues with your follow up ideas. But I think we should start with the low hanging fruit of what I just outlined. What do you think?

@corydickson
Copy link

I think we are speaking of similar things for the ENS resolution, and agree that's the best place to start. Do you think that verifying the on-chain bytecode against what is already inside the database to be a fruitful check? The reasoning behind this was so that we could prevent duplicate contracts being added to the database i.e two of the same runtime bytecodes would map to a 0x address and ENS name and would be treated as separate entities

@ligi
Copy link
Member Author

ligi commented Mar 28, 2020

AFAIK duplication cannot happen for exact matches which we only support currently. It might become an issue when partial matches are supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants