Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Network): add support for net id of Goerli #3095

Merged

Conversation

JayWelsh
Copy link
Contributor

@JayWelsh JayWelsh commented Oct 2, 2019

Support for identification of Goerli test net via getNetworkType function.

@coveralls
Copy link

coveralls commented Oct 2, 2019

Coverage Status

Coverage increased (+0.1%) to 83.242% when pulling c579ecb on JayWelsh:feature/add-goerli-identification-support-1.x into 5035b25 on ethereum:1.x.

@nivida nivida added 1.x 1.0 related issues Enhancement Includes improvements or optimizations labels Oct 8, 2019
Copy link
Contributor

@nivida nivida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proposing this PR! Could you update the changelog file in the root folder of the 1.x branch?

@nivida nivida merged commit c1db2ca into web3:1.x Oct 8, 2019
@JayWelsh
Copy link
Contributor Author

JayWelsh commented Oct 8, 2019

Thanks so much @nivida !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Enhancement Includes improvements or optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants