Signing fixes back-ported from 2.x #3125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nivida
added
Bug
cgewecke
reviewed
Oct 13, 2019
cgewecke
reviewed
Oct 13, 2019
cgewecke
approved these changes
Oct 13, 2019
…' prefix added to messageHash for consistency reasons
|
@nivida Apologies, I missed something important in the review here. Additionally, there was a bug in the E2E CI (fixed with #3138) which meant it wasn't obvious an eth.accounts.sign test was failing for geth dev. The problem is that ethereumjs-tx requires an additional object passed to the Transaction constructor when a tx is being sent to a non-mainnet chain. You can see an example in the ejs-tx signing test removed from #3122. |
This was referenced Mar 31, 2020
This was referenced Apr 10, 2020
nachomazzara
pushed a commit
to nachomazzara/web3.js
that referenced
this pull request
Jun 4, 2020
* signing fixes back-ported from 2.x * CHANGELOG.md updated * transactionHash property added, docs updated, tests extended, and '0x' prefix added to messageHash for consistency reasons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1998, #2033, and #1074