Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types back-port from 2.x with changes to match the 1.x logic #3132

Merged
merged 126 commits into from
Oct 16, 2019
Merged

Types back-port from 2.x with changes to match the 1.x logic #3132

merged 126 commits into from
Oct 16, 2019

Conversation

joshstevens19
Copy link
Contributor

@joshstevens19 joshstevens19 commented Oct 15, 2019 •
edited
Loading

Back porting the types we did in 2.x web3 into 1.x. Some modules were different in 1.x so had to reshape some of where the types lived apart from that it works as it does in 2.0.

Please go through and see if you spot any interfaces which were changed in 2.x but the public interface stayed the same throughout versions.

image

all types pass. 👍

This fixes a lot of the TS issues to get web3 1.0 stable here > #3070

@joshstevens19
docs: update readme to contain TS usage
05ee451
@joshstevens19
feat: learna dtslint
5e58e55
@joshstevens19
feat: types for web3 module
9bf6bdd
@joshstevens19
feat: web3 module install dtslint
e62daff
@joshstevens19
docs: readme web3 module types
321fc59
@joshstevens19
feat: web3-core types
073d112
@joshstevens19
docs: update readme for web3-core for types
943fe29
@joshstevens19
feat: install type dependencies for web3-core
7cfd476
@joshstevens19
feat: web3-core-helper types
ba08495
@joshstevens19
feat: install type dependency for web3-core-helpers
a49b021
@joshstevens19
docs: update readme for typings
44dc1e9
@joshstevens19
fix: remove @types/node from web3-core-helpers
0229985
@joshstevens19
feat: web3-core-method types
f6d7888
@joshstevens19
feat: install type dependencies for web3-core-method
64b74ec
@joshstevens19
docs: update types for web3-core-method in readme
e1d37ac
@joshstevens19
feat: web3-eth typings
4ca1cf8
@joshstevens19
feat: install type dependencies for web3-eth
eb9b819
@joshstevens19
docs: update readme for web3-eth
6a34aaf
@joshstevens19
feat: web3-eth-abi typings
e4f085f
@joshstevens19
feat: install type dependencies for web3-eth-abi
7800a02
@joshstevens19
docs: update readme for web3-eth-abi
06245fa
@joshstevens19
feat: web3-eth-accounts typings
4af7781
@joshstevens19
feat: install type dependencies for web3-eth-accounts
27fe1d0
@joshstevens19
docs: update readme for web3-eth-accounts
704d7e2
@joshstevens19
feat: web3-eth-contract typings
c3b750f
@joshstevens19
feat: web3-eth-contract tests
261dbd8
@joshstevens19
feat: install types dependencies for web3-eth-contract
136378a
@joshstevens19
docs: update readme for web3-eth-contract
c224ed3
@joshstevens19
feat: web3-eth-ens typings
ff8fadb
@joshstevens19
test: web3-eth-ens tests
dc87499
@joshstevens19 joshstevens19 removed the In Progress Currently being worked on label Oct 16, 2019
@nivida nivida merged commit 8ac5c0e into web3:1.x Oct 16, 2019
@joshstevens19 joshstevens19 deleted the types/back-port-from-2.x branch October 16, 2019 14:47
@nivida nivida mentioned this pull request Oct 21, 2019
Merged
11 tasks
@snyk-bot snyk-bot mentioned this pull request Feb 4, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Open
This was referenced Mar 31, 2020
Open
Open
Open
Open
This was referenced Apr 9, 2020
Open
Open
Open
nachomazzara pushed a commit to nachomazzara/web3.js that referenced this pull request Jun 4, 2020
@joshstevens19 @nachomazzara
Types back-port from 2.x with changes to match the 1.x logic (web3#3132)
af89325 
* docs: update readme to contain TS usage

* feat: learna dtslint

* feat: types for `web3` module

* feat: `web3` module install dtslint

* docs: readme web3 module types

* feat: `web3-core` types

* docs: update readme for `web3-core` for types

* feat: install type dependencies for `web3-core`

* feat: `web3-core-helper` types

* feat: install type dependency for `web3-core-helpers`

* docs: update readme for typings

* fix: remove @types/node from `web3-core-helpers`

* feat: `web3-core-method` types

* feat: install type dependencies for `web3-core-method`

* docs: update types for `web3-core-method` in readme

* feat: `web3-eth` typings

* feat: install type dependencies for `web3-eth`

* docs: update readme for `web3-eth`

* feat: `web3-eth-abi` typings

* feat: install type dependencies for `web3-eth-abi`

* docs: update readme for `web3-eth-abi`

* feat: `web3-eth-accounts` typings

* feat: install type dependencies for `web3-eth-accounts`

* docs: update readme for `web3-eth-accounts`

* feat: `web3-eth-contract` typings

* feat: `web3-eth-contract` tests

* feat: install types dependencies for `web3-eth-contract`

* docs: update readme for `web3-eth-contract`

* feat: `web3-eth-ens` typings

* test: `web3-eth-ens` tests

* feat: install type dependencies for `web3-eth-ens`

* docs: update readme for `web3-eth-ens`

* feat: `web3-eth-iban` typings

* test: `web3-eth-iban` typing tests

* feat: install `web3-eth-iban` typings dependencies

* docs: update readme for `web3-eth-iban`

* feat: `web3-eth-personal` typings

* test: `web3-eth-personal` typings tests

* feat: install dependencies for `web3-eth-personal`

* docs: update readme `web3-eth-personal`

* feat: `web3-net` typings

* fix: remove dev dependencies which are not relavant

* test: `web3-net` typings tests

* docs: update readme for `web3-net`

* feat: install dev dependencies for `web3-net`

* feat: `web3-shh` typings

* test: `web3-shh` typings tests

* docs: update `web3-shh` readme

* feat: install dev dependencies in `web3-shh`

* feat: web3-utils type config files

* feat: ascii to hex typings test

* feat: bytes to hex typings test

* feat: check address checksum typings test

* feat: from ascii typings test

* feat: from decimal typings test

* feat: from utf8 typings test

* feat: from wei typings test

* feat: get signature params typings test

* feat: get unit value typings test

* feat: hex to ascii typings test

* feat: hex to bytes typings test

* feat: hex to number string typings test

* feat: hex to number typings test

* feat: hex to string typings test

* feat: hex to utf8 typings test

* feat: is address typings test

* feat: is big number typings test

* feat: is bloom typings test

* feat: is bn typings test

* feat: is hex strict typings test

* feat: is hex typings test

* feat: is topic typings test

* feat: json interface method to string typings test

* feat: keccak256 typings test

* feat: left pad typings test

* feat: number to hex typings test

* feat: utils type tests

* feat: add types in package.json

* feat: new lock files for all packages

* feat: new lock files for web3-eth-account

* feat: new lock file for web3-provider.ws

* feat: install new dev dependencies for typings on root

* feat: export the typings in the package.json

* feat: web3 typings tests to reference web3-core

* feat: reference web3-core over web3-providers

* feat: typings moved around due to different approach in 2.x

* feat: web3-bzz types

* feat: web3-bzz dependencies

* test: web3 bzz types

* fix: resolve dtslint typing tests fails

* feat: web3-provider-http types

* test: web3-provider-http tests

* refactor: rename to `tests`

* docs: add author to the http provider

* feat: install web3-provider-ipc new dev dependencies

* docs: update readme for web3-provider-ipc

* feat: `web3-providers-ipc`  typings

* test: web3-provider-ipc test typings

* feat: typings for web3-providers-ipc

* fix: remove file comment

* fix: resolve index.d.ts file

* feat: install type dependencies for web3-provider-ws

* feat: `web-providers-ws` typings

* feat: web3-providers-ws ts files

* test: web3-provider-ws-tests

* fix: remove batch request from web3-bzz

* feat: export errors from web3-core-helpers

* fix: remove options from `web3.shh`

* fix: define callback in the filter methods

* feat: remove `TransactionSigner`

* docs: add web3-eth-personal docs

* fix: resolve typings 1.0 from pr comments

* types updated

* ci script updated

* global install of typescript for CI added

* installation of typescript moved to before_script

* lerna-debug.log added to gitignore

* lerna-debug removed

* getNodeInfo added to types and documentation

* getChainId to types added

* travis.yml fixed

* global install of typescript removed and just added as dependency to the root package.json

* fix: dtslint to version `0.4.2`

* fix: remove repeating typings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgewecke cgewecke Awaiting requested review from cgewecke

@nivida nivida Awaiting requested review from nivida

Assignees
No one assigned
Labels
1.x 1.0 related issues Types Incorrect or missing types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshstevens19 @coveralls @cgewecke @nivida