Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes transaction confirmations with the HttpProvider #3140

Merged
merged 9 commits into from
Oct 17, 2019
Merged

Fixes transaction confirmations with the HttpProvider #3140

merged 9 commits into from
Oct 17, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Oct 17, 2019

Back-ports #1239 which is listed in issue #3070.

@nivida nivida added Enhancement Includes improvements or optimizations In Progress Currently being worked on 1.x 1.0 related issues labels Oct 17, 2019
@nivida nivida requested a review from cgewecke October 17, 2019 09:02
@nivida nivida removed the In Progress Currently being worked on label Oct 17, 2019
@alcuadrado alcuadrado mentioned this pull request Oct 17, 2019
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 84.465% when pulling d0776ee on back-port/1239 into 400d24b on 1.x.

@nivida nivida merged commit 4ffa27b into 1.x Oct 17, 2019
@nivida nivida removed the request for review from cgewecke October 17, 2019 12:12
@nivida nivida deleted the back-port/1239 branch October 17, 2019 16:05
@nivida nivida mentioned this pull request Oct 21, 2019
Merged
11 tasks
@snyk-bot snyk-bot mentioned this pull request Feb 4, 2020
Open
@nventuro nventuro mentioned this pull request Feb 5, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Open
This was referenced Mar 31, 2020
Open
Open
Open
Open
This was referenced Apr 9, 2020
Open
Open
Open
nachomazzara pushed a commit to nachomazzara/web3.js that referenced this pull request Jun 4, 2020
@nivida @nachomazzara
Fixes transaction confirmations with the HttpProvider (web3#3140)
f6e8c9e 
* confirmations are now only emitted if a new block is actually existing

* CHANGELOG.md updated

* CHANGELOG.md 'Added' section updated with the added types

* build packages updated

* istanbul updated because of the usage of 'async', contract.js test codestyle improved, and transaction confirmation handling in the Method class of the web3-core-method module

* coveralls CI script updated

* coverage paths updated in e2e.ganache.sh, e2e.geth.automine.sh, e2e.geth.instamine.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.x 1.0 related issues Enhancement Includes improvements or optimizations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nivida @coveralls