Prefer receipt status to code availability on contract deployment #3298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgewecke
changed the title
cgewecke
commented
Jan 7, 2020
| var gethRevert = "code couldn't be stored"; | ||
| var revertMessage = "revert"; | ||
| var couldNotBeStoredMessage = "code couldn't be stored"; | ||
| var creationWithoutDataMessage = "contract creation without any data provided"; |
There was a problem hiding this comment.
This message emitted by geth, code ref here
cgewecke
added
1.x
nivida
approved these changes
Jan 9, 2020
This was referenced Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses problem described in truffle 2257 where the availability of the contract code in the client DB lags the delivery of the tx receipt on deployment. Web3 tries to fetch the code immediately, can't find anything and errors with
At the moment people frequently see successful contract deployments reported as failures
Commit 17f72d7 adds additional tests cases which hit this error, to establish a behavioral baseline for the logic change.
Commit aec5c08 adds logic to allow any deployment which had a 'real' bytecode and a true receipt status to be treated as successful.
The code length check is kept as an alternative for pre-byzantium chains and to preserve current behavior when deploying zero length bytecodes to ganache (e.g should error).
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:unitwith success and extended the tests if necessary.npm run build-alland tested the resulting file/'s fromdistfolder in a browser.CHANGELOG.mdfile in the root folder.