Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AbiCoder param formatting #3522

Merged
merged 2 commits into from
May 18, 2020
Merged

Conversation

ryanio
Copy link
Collaborator

@ryanio ryanio commented May 15, 2020

Description

This PR improves AbiCoder param formatting in encoding as to reduce any breaking changes with the AbiCoder dep update in #3490.

Thanks to #3510 (comment) it accommodates formatting fixed byte lengths and (u)int widths.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build-all and tested the resulting files from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@ryanio ryanio added 1.x 1.0 related issues Release Patch labels May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Release Patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants