Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Flaky Parity Shh Module integration tests #1408

Closed
kclowes opened this issue Aug 1, 2019 · 0 comments
Closed

Fix Flaky Parity Shh Module integration tests #1408

kclowes opened this issue Aug 1, 2019 · 0 comments

Comments

@kclowes
Copy link
Collaborator

kclowes commented Aug 1, 2019

What was wrong?

Two intermittent test failures have popped up in the parity shh module.
tests/integration/parity/test_parity_ipc.py::TestParityShhModuleTest::test_shh_remove_filter
tests/integration/parity/test_parity_ipc.py::TestParityShhModuleTest::test_shh_post

See this circle run for the full output.

How can it be fixed?

Looking at the history of the failures, I suspect it has to do with the refactoring of the parity tests (#1355), but I'm not sure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kclowes