Ethpm contract types property #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
ethpm-contract-types-property
branch
3 times, most recently
from
de818a4
to
eac39c9
Compare
njgheorghita
force-pushed
the
ethpm-contract-types-property
branch
from
eac39c9
to
8989750
Compare
kclowes
approved these changes
Aug 29, 2019
| for deployment_name, deployment_data in deployments.items(): | ||
| if deployment_data['contract_type'] not in contract_types: | ||
| if deployment_data['contract_type'] not in self.contract_types: |
There was a problem hiding this comment.
Will you always have deployment data here? If not, it's probably worth a check:
if deployment_data and deployment_data['contract_type'] not in self.contract_types:
...
There was a problem hiding this comment.
Ahh good thought - but we check for deployments on line 346 / so if people are using this private method correctly (via Package.deployments and not directly ) then we should be ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Package.contract_typesproperty to easily access all available contract types in a package.Package.from_uritestsTodo:
Cute Animal Picture