Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade py-evm to 0.2.0 beta #1451

Merged
merged 1 commit into from
Sep 16, 2019
Merged

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Sep 13, 2019

What was wrong?

Piper pointed out that Jason did a bunch of work to make py-evm much faster 🔥 tests now go so fast 🚗💨

How was it fixed?

Added new dependency requirement

Todo:

Cute Animal Picture

image

@carver
Copy link
Collaborator

carver commented Sep 13, 2019

tests now go so fast

Glad to hear it. Just curious if you have it available: what kinds of speedups were you seeing? Always curious to see the impact on different workloads.

@@ -0,0 +1 @@
Upgrade py-evm to 0.2.0-beta.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the eth-tester version. (in this eth-tester, py-evm is upgraded to https://py-evm.readthedocs.io/en/latest/release_notes.html#v0-3-0-alpha-1 )

Maybe worth noting that that version of py-evm is now 3 months old, with ~5 releases since, so another upgrade and bump of py-evm inside eth-tester might be worthwhile.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the eth-tester version

Oops, nice catch!

And upgrading eth-tester again seems like a good idea!

@kclowes
Copy link
Collaborator Author

kclowes commented Sep 14, 2019

I specifically noticed the ‘tests/core/contracts’ specs were faster. I didn't look at the actual numbers but they’d be quick to get if you want!

Copy link
Member

@pipermerriam pipermerriam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good-to-go as-is but as I think @carver pointed out, you'll probably see another noticeable improvement if you do the upstream upgrade to the very latest py-evm in the eth-tester libarary.

@kclowes kclowes merged commit ed066eb into ethereum:master Sep 16, 2019
@kclowes kclowes deleted the upgrade-pyevm-020 branch September 16, 2019 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants