export poll_latency #1453
Merged
export poll_latency #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @m3ngyang! Will you add the new parameter to the docs when you get a chance? |
|
@kclowes doc test has been fixed. |
kclowes
reviewed
Sep 19, 2019
| @@ -65,7 +65,7 @@ def fill_transaction_defaults(web3, transaction): | |||
| return merge(defaults, transaction) | |||
|
|
|||
|
|
|||
| def wait_for_transaction_receipt(web3, txn_hash, timeout=120, poll_latency=0.1): | |||
There was a problem hiding this comment.
@pipermerriam is there any reason to keep the defaults here? The only place this method is used is in eth.waitForTransactionReceipt
|
@m3ngyang I added a newsfragment for the release notes and cleaned up a little bit. Let me know if it doesn't look right. Otherwise, I think this is good to go! |
|
@kclowes the patch looks good to me. |
This was referenced Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #1435
How was it fixed?
export poll_latency parameter in waitForTransactionReceipt
Todo:
Cute Animal Picture