Change UnlockAccount duration #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/web3.geth.rst
Outdated
| ``None`` then the account will remain unlocked indefinitely. Returns | ||
| boolean as to whether the account was successfully unlocked. | ||
| Unlocks the given ``account`` for ``duration`` seconds. If ``duration`` is | ||
| ``None`` then the account will remain unlocked for 300 seconds (which is current default by Geth), |
There was a problem hiding this comment.
Can you add the version number of geth to this.
There was a problem hiding this comment.
you mean
(which is current default by Geth) => (which is current default by Geth v1.9.5)
right?
kclowes
pushed a commit
to kclowes/web3.py
that referenced
this pull request
Nov 13, 2019
* Change UnlockAccount duration * fixed test * Add geth version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #1462
How was it fixed?
Change docs about geth.personal.unlockAccount
Todo:
Cute Animal Picture